You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2024/01/02 12:37:21 UTC
Re: [PR] [SPARK-46552][SQL] Replace `UnsupportedOperationException` by `SparkUnsupportedOperationException` in `catalyst` [spark]
LuciferYang commented on code in PR #44549:
URL: https://github.com/apache/spark/pull/44549#discussion_r1439407428
##########
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java:
##########
@@ -17,10 +17,13 @@
package org.apache.spark.sql.catalyst.expressions.codegen;
+import org.apache.spark.SparkUnsupportedOperationException;
import org.apache.spark.sql.catalyst.expressions.UnsafeRow;
import org.apache.spark.unsafe.Platform;
import org.apache.spark.unsafe.array.ByteArrayMethods;
+import java.util.Map;
Review Comment:
ditto
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/DeltaWriteBuilder.java:
##########
@@ -17,8 +17,11 @@
package org.apache.spark.sql.connector.write;
+import org.apache.spark.SparkUnsupportedOperationException;
import org.apache.spark.annotation.Experimental;
+import java.util.Map;
Review Comment:
ditto
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/Scan.java:
##########
@@ -26,6 +27,8 @@
import org.apache.spark.sql.connector.catalog.Table;
import org.apache.spark.sql.connector.catalog.TableCapability;
+import java.util.Map;
Review Comment:
ditto
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/Write.java:
##########
@@ -17,12 +17,15 @@
package org.apache.spark.sql.connector.write;
+import org.apache.spark.SparkUnsupportedOperationException;
import org.apache.spark.annotation.Evolving;
import org.apache.spark.sql.connector.catalog.Table;
import org.apache.spark.sql.connector.catalog.TableCapability;
import org.apache.spark.sql.connector.metric.CustomMetric;
import org.apache.spark.sql.connector.write.streaming.StreamingWrite;
+import java.util.Map;
Review Comment:
ditto
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/DeltaWrite.java:
##########
@@ -17,8 +17,11 @@
package org.apache.spark.sql.connector.write;
+import org.apache.spark.SparkUnsupportedOperationException;
import org.apache.spark.annotation.Experimental;
+import java.util.Map;
Review Comment:
ditto
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/WriteBuilder.java:
##########
@@ -17,9 +17,12 @@
package org.apache.spark.sql.connector.write;
+import org.apache.spark.SparkUnsupportedOperationException;
import org.apache.spark.annotation.Evolving;
import org.apache.spark.sql.connector.write.streaming.StreamingWrite;
+import java.util.Map;
Review Comment:
ditto
##########
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/SpecializedGettersReader.java:
##########
@@ -17,9 +17,12 @@
package org.apache.spark.sql.catalyst.expressions;
+import org.apache.spark.SparkUnsupportedOperationException;
import org.apache.spark.sql.catalyst.types.*;
import org.apache.spark.sql.types.*;
+import java.util.Map;
Review Comment:
`import java.util.Map` should before `import org.apache.spark.*`
##########
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatchRow.java:
##########
@@ -25,6 +26,8 @@
import org.apache.spark.unsafe.types.UTF8String;
import org.apache.spark.unsafe.types.VariantVal;
+import java.util.Map;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org