You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "YesOrNo828 (via GitHub)" <gi...@apache.org> on 2023/10/18 10:52:08 UTC
[PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
YesOrNo828 opened a new pull request, #5465:
URL: https://github.com/apache/kyuubi/pull/5465
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Resolve: #5405 Support the Flink 1.18
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
<!--
If a generative AI tooling has been used in the process of authoring this patch, please include
phrase 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#issuecomment-1778771554
Thanks, merged to master/1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#issuecomment-1768599096
@YesOrNo828 CI passed, thanks. The Flink community is preparing for RC3, let's hold on for a few days, and keep updated with the latest RC until Flink 1.18.0 GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363733482
##########
.github/workflows/master.yml:
##########
@@ -183,13 +183,18 @@ jobs:
flink:
- '1.16'
- '1.17'
+ - '1.18'
flink-archive: [ "" ]
comment: [ "normal" ]
include:
- java: 8
flink: '1.17'
flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.16.1 -Dflink.archive.name=flink-1.16.1-bin-scala_2.12.tgz'
comment: 'verify-on-flink-1.16-binary'
+ - java: 8
+ flink: '1.17'
+ flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.18.0 -Dflink.archive.name=flink-1.18.0-bin-scala_2.12.tgz'
Review Comment:
the staging repo is required at the RC stage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "YesOrNo828 (via GitHub)" <gi...@apache.org>.
YesOrNo828 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363705036
##########
.github/workflows/master.yml:
##########
@@ -53,9 +53,9 @@ jobs:
- '3.3'
- '3.4'
- '3.5'
- spark-archive: [""]
- exclude-tags: [""]
- comment: ["normal"]
+ spark-archive: [ "" ]
+ exclude-tags: [ "" ]
+ comment: [ "normal" ]
Review Comment:
Due to the 'Action on Save' tool reformat the yml code. I have reverted the cord.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#issuecomment-1778583414
Also cc @link3280 and @SteNicholas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "link3280 (via GitHub)" <gi...@apache.org>.
link3280 commented on PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#issuecomment-1778794264
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363673535
##########
.github/workflows/master.yml:
##########
@@ -183,13 +183,18 @@ jobs:
flink:
- '1.16'
- '1.17'
+ - '1.18'
flink-archive: [ "" ]
comment: [ "normal" ]
include:
- java: 8
flink: '1.17'
flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.16.1 -Dflink.archive.name=flink-1.16.1-bin-scala_2.12.tgz'
comment: 'verify-on-flink-1.16-binary'
+ - java: 8
+ flink: '1.18'
+ flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.17.1 -Dflink.archive.name=flink-1.17.1-bin-scala_2.12.tgz'
+ comment: 'verify-on-flink-1.17-binary'
Review Comment:
Emm... this cross-verification is actually to sure the Flink engine which builds against the default Flink version can work well on all support Flink runtimes.
Specific to this case, it should be: using flink 1.17 for compilation, and verifying that it works well on Flink 1.18 runtime
##########
.github/workflows/master.yml:
##########
@@ -487,7 +492,7 @@ jobs:
fail-fast: false
matrix:
java: [ 8 ]
- zookeeper: ["3.4", "3.5", "3.6", "3.7" ]
+ zookeeper: [ "3.4", "3.5", "3.6", "3.7" ]
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "YesOrNo828 (via GitHub)" <gi...@apache.org>.
YesOrNo828 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363671190
##########
pom.xml:
##########
@@ -2300,6 +2300,22 @@
</properties>
</profile>
+ <profile>
+ <id>flink-1.18</id>
+ <properties>
+ <flink.version>1.18.0</flink.version>
+ </properties>
+ <repositories>
Review Comment:
Since the Flink 1.18 is currently in the release candidate stage, the repository will be removed after the stable binary release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363673535
##########
.github/workflows/master.yml:
##########
@@ -183,13 +183,18 @@ jobs:
flink:
- '1.16'
- '1.17'
+ - '1.18'
flink-archive: [ "" ]
comment: [ "normal" ]
include:
- java: 8
flink: '1.17'
flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.16.1 -Dflink.archive.name=flink-1.16.1-bin-scala_2.12.tgz'
comment: 'verify-on-flink-1.16-binary'
+ - java: 8
+ flink: '1.18'
+ flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.17.1 -Dflink.archive.name=flink-1.17.1-bin-scala_2.12.tgz'
+ comment: 'verify-on-flink-1.17-binary'
Review Comment:
Emm... this cross-verification is actually to ensure the Flink engine which builds against the default Flink version can work well on all support Flink runtimes.
Specific to this case, it should be: using flink 1.17 for compilation, and verifying that it works well on Flink 1.18 runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "YesOrNo828 (via GitHub)" <gi...@apache.org>.
YesOrNo828 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363706603
##########
.github/workflows/master.yml:
##########
@@ -183,13 +183,18 @@ jobs:
flink:
- '1.16'
- '1.17'
+ - '1.18'
flink-archive: [ "" ]
comment: [ "normal" ]
include:
- java: 8
flink: '1.17'
flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.16.1 -Dflink.archive.name=flink-1.16.1-bin-scala_2.12.tgz'
comment: 'verify-on-flink-1.16-binary'
+ - java: 8
+ flink: '1.18'
+ flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.17.1 -Dflink.archive.name=flink-1.17.1-bin-scala_2.12.tgz'
+ comment: 'verify-on-flink-1.17-binary'
Review Comment:
Thanks for your explanation. I've changed the flink version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#issuecomment-1776731493
flink1.18-rc3 vote passed
https://www.mail-archive.com/dev@flink.apache.org/msg70644.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5465: [KYUUBI #5405] [FLINK] Support Flink 1.18
URL: https://github.com/apache/kyuubi/pull/5465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363674329
##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkEngineUtils.scala:
##########
@@ -119,7 +119,7 @@ object FlinkEngineUtils extends Logging {
.build()
.newInstance(flinkConf, commandLines)
.asInstanceOf[DefaultContext]
- } else if (FLINK_RUNTIME_VERSION === "1.17") {
+ } else if (FLINK_RUNTIME_VERSION === "1.17" || FLINK_RUNTIME_VERSION === "1.18") {
Review Comment:
how about
```suggestion
} else if (FLINK_RUNTIME_VERSION >= "1.17") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363669738
##########
.github/workflows/master.yml:
##########
@@ -53,9 +53,9 @@ jobs:
- '3.3'
- '3.4'
- '3.5'
- spark-archive: [""]
- exclude-tags: [""]
- comment: ["normal"]
+ spark-archive: [ "" ]
+ exclude-tags: [ "" ]
+ comment: [ "normal" ]
Review Comment:
please avoid such unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363714558
##########
pom.xml:
##########
@@ -2300,6 +2300,22 @@
</properties>
</profile>
+ <profile>
+ <id>flink-1.18</id>
+ <properties>
+ <flink.version>1.18.0</flink.version>
+ </properties>
+ <repositories>
Review Comment:
it's also required to override `flink.archive.mirror`, it is used to download flink runtime tgz for integration testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "YesOrNo828 (via GitHub)" <gi...@apache.org>.
YesOrNo828 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1363705036
##########
.github/workflows/master.yml:
##########
@@ -53,9 +53,9 @@ jobs:
- '3.3'
- '3.4'
- '3.5'
- spark-archive: [""]
- exclude-tags: [""]
- comment: ["normal"]
+ spark-archive: [ "" ]
+ exclude-tags: [ "" ]
+ comment: [ "normal" ]
Review Comment:
Due to the 'Action on Save' tool reformat the yml code. I have reverted the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#discussion_r1364787221
##########
.github/workflows/master.yml:
##########
@@ -183,13 +183,18 @@ jobs:
flink:
- '1.16'
- '1.17'
+ - '1.18'
flink-archive: [ "" ]
comment: [ "normal" ]
include:
- java: 8
flink: '1.17'
flink-archive: '-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.16.1 -Dflink.archive.name=flink-1.16.1-bin-scala_2.12.tgz'
comment: 'verify-on-flink-1.16-binary'
+ - java: 8
+ flink: '1.17'
+ flink-archive: '-Dflink.archive.mirror=https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc2 -Dflink.archive.name=flink-1.18.0-bin-scala_2.12.tgz'
Review Comment:
```suggestion
flink-archive: '-Dflink.archive.mirror=https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc3 -Dflink.archive.name=flink-1.18.0-bin-scala_2.12.tgz'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5405] [FLINK] Support Flink 1.18 [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5465:
URL: https://github.com/apache/kyuubi/pull/5465#issuecomment-1768817399
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5465](https://app.codecov.io/gh/apache/kyuubi/pull/5465?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (99172e3) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/f6ccc4d80fc925d51540595c3b18556c220dd70e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f6ccc4d) will **not change** coverage.
> Report is 9 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5465 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33450 33455 +5
Branches 4400 4401 +1
======================================
- Misses 33450 33455 +5
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/5465/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org