[jira] [Commented] (LUCENE-2548) Remove all interning of field names from flex API

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034393#comment-13034393 ] 

Robert Muir commented on LUCENE-2548:
-------------------------------------

after seeing LUCENE-3105, i think we should take steps to remove this interning.

it looks like this can probably be done safely, according to http://www.cs.umd.edu/~jfoster/papers/issre04.pdf , findbugs, PMD, and JLint all support looking for string equality with == or !=, so we should be able to review all occurrences.

> Remove all interning of field names from flex API
> -------------------------------------------------
>
>                 Key: LUCENE-2548
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2548
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>             Fix For: 4.0
>
>
> In previous versions of Lucene, interning of fields was important to minimize string comparison cost when iterating TermEnums, to detect changes in field name. As we separated field names from terms in flex, no query compares field names anymore, so the whole performance problematic interning can be removed. I will start with doing this, but we need to carefully review some places e.g. in preflex codec.
> Maybe before this issue we should remove the Term class completely. :-) Robert?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org