You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/02/04 17:09:41 UTC
[GitHub] [tinkerpop] nterzenidis opened a new pull request #1562: Python logging under a separate logger "gremlinpython"
nterzenidis opened a new pull request #1562:
URL: https://github.com/apache/tinkerpop/pull/1562
Added logger object "gremlinpython" wherever logging is used in order to adhere to python logging best practices.
Otherwise the logs are recorded in the root logger object which is not practical, as the logs cannot be distinguished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1562: Python logging under a separate logger "gremlinpython"
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1562:
URL: https://github.com/apache/tinkerpop/pull/1562#issuecomment-1033191773
VOTE +1 - i can add a changelog entry on squash/merge - thanks @nterzenidis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1562: Python logging under a separate logger "gremlinpython"
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1562:
URL: https://github.com/apache/tinkerpop/pull/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonb-bq commented on pull request #1562: Python logging under a separate logger "gremlinpython"
Posted by GitBox <gi...@apache.org>.
lyndonb-bq commented on pull request #1562:
URL: https://github.com/apache/tinkerpop/pull/1562#issuecomment-1032852231
Took a look over the changes, they look good to me. Thanks for the change @nterzenidis.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org