[jira] [Commented] (NIFI-5114) Support Basic Authentication at WebSocket components

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449418#comment-16449418 ] 

ASF GitHub Bot commented on NIFI-5114:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/2652

    NIFI-5114: Added Basic auth support to WebSocket components

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-5114

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2652
    
----
commit 65a86f55cb35cff9e5bfa3943e5d6629156d6d73
Author: Koji Kawamura <ij...@...>
Date:   2018-04-23T02:38:20Z

    NIFI-5114: Added Basic auth support to WebSocket components

----


> Support Basic Authentication at WebSocket components
> ----------------------------------------------------
>
>                 Key: NIFI-5114
>                 URL: https://issues.apache.org/jira/browse/NIFI-5114
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>            Priority: Major
>
> Some WebSocket server uses Basic Authentication for WebSocket upgrade requests. In order to connect such endpoints, NiFi should allow users to configure user name and password at WebSocket client component. Specifically JettyWebSocketClientService.
> In addition to that, if JettyWebSocketServerService can be configured to use Basic Authentication, it makes NiFi WebSocket server more secure and also useful to test Basic Auth between NiFi WebSocket client components. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)