You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/06/17 10:26:55 UTC
[maven-wagon] 01/01: [WAGON-627] Maven deploy fails with 401 Unauthorized when using £ in password
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch WAGON-627/fix
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit d7f336745a6fec7c3697e47b17f46b9ae996d305
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Fri Jun 17 12:23:17 2022 +0200
[WAGON-627] Maven deploy fails with 401 Unauthorized when using £ in password
When configuring preemptive authentication we need to make sure that it uses
the same character encoding as the custom auth scheme registry. Then characters
are properly encoded into bytes.
This closes #83
---
.../org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java | 4 ++--
.../java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
index 01f09bc0..bb787771 100644
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -779,7 +779,7 @@ public abstract class AbstractHttpClientWagon
if ( credentialsProvider.getCredentials( targetScope ) != null )
{
- BasicScheme targetAuth = new BasicScheme();
+ BasicScheme targetAuth = new BasicScheme( StandardCharsets.UTF_8 );
authCache.put( targetHost, targetAuth );
}
@@ -978,7 +978,7 @@ public abstract class AbstractHttpClientWagon
if ( credentialsProvider.getCredentials( targetScope ) != null )
{
- BasicScheme targetAuth = new BasicScheme();
+ BasicScheme targetAuth = new BasicScheme( StandardCharsets.UTF_8 );
authCache.put( targetHost, targetAuth );
}
}
diff --git a/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java b/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java
index 2aac4403..22c1ee42 100644
--- a/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java
+++ b/wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/WebDavWagon.java
@@ -50,6 +50,7 @@ import org.w3c.dom.Node;
import java.io.File;
import java.io.IOException;
import java.net.URLDecoder;
+import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.List;
@@ -165,7 +166,7 @@ public class WebDavWagon
if ( getCredentialsProvider().getCredentials( targetScope ) != null )
{
- BasicScheme targetAuth = new BasicScheme();
+ BasicScheme targetAuth = new BasicScheme( StandardCharsets.UTF_8 );
getAuthCache().put( targetHost, targetAuth );
}
HttpMkcol method = new HttpMkcol( url );