You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jerry-024 (via GitHub)" <gi...@apache.org> on 2026/08/14 06:08:43 UTC
[PR] feat: add vector search timing logs [paimon-rust]
jerry-024 opened a new pull request, #711:
URL: https://github.com/apache/paimon-rust/pull/711
<!--
Thank you very much for contributing to Paimon Rust - we are happy that you want to help us improve it. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for typos in documentation or comments, which need no issue.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `cargo test` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List unit tests or integration cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature or require documentation updates -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add opt-in vector search timing diagnostics [paimon-rust]
Posted by "jerry-024 (via GitHub)" <gi...@apache.org>.
jerry-024 commented on PR #711:
URL: https://github.com/apache/paimon-rust/pull/711#issuecomment-5311487614
One remaining latency gap is worth covering in this PR: `RangeIoStats` records amplification counters, but not the wall time spent waiting for range reads. The blocking `pread -> read_ranges -> runtime.spawn -> sync_channel::recv` path is therefore folded into `native_search_wall_ms`, so remote-storage wait cannot be separated from native search work.
Could we add a shared `AtomicU64` such as `range_read_wait_nanos` and accumulate the duration around `recv()`? The name should avoid claiming this is pure I/O time: it also includes runtime scheduling, the internal range-read permit queue, and result delivery. This would partially cover the missing range-read permit signal as well.
The Lumina/full-file fallback paths can remain follow-up work, and the non-batch path is outside this PR's stated scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add vector search timing and I/O diagnostics [paimon-rust]
Posted by "jerry-024 (via GitHub)" <gi...@apache.org>.
jerry-024 merged PR #711:
URL: https://github.com/apache/paimon-rust/pull/711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add opt-in vector search timing diagnostics [paimon-rust]
Posted by "shyjsarah (via GitHub)" <gi...@apache.org>.
shyjsarah commented on code in PR #711:
URL: https://github.com/apache/paimon-rust/pull/711#discussion_r3793750490
##########
crates/paimon/src/vindex/reader.rs:
##########
@@ -225,13 +296,16 @@ impl VindexVectorGlobalIndexReader {
message: "vindex metadata not initialized".to_string(),
source: None,
})?;
- search_batch_vindex(
+ let (results, batch_stats) = search_batch_vindex(
reader,
metadata,
&self.options,
vector_searches,
self.batch_index_parallelism,
- )
+ self.timing_enabled,
+ )?;
+ self.batch_stats = batch_stats;
Review Comment:
**Minor:** `search_batch()` stores the collected stats on the reader, but only `visit_batch_vector_search()` consumes them and emits `paimon_vindex_reader`. The PK-vector scorer calls `load_validated()` + `search_batch()` directly (`vector_search_builder.rs:923-935`), so with timing enabled that route collects batch/range-I/O diagnostics but returns without publishing them.
Could we make telemetry reporting independent of the convenience wrapper (for example, return/commit the stats from the search API or pass an explicit diagnostics reporter), and add coverage for the PK/hybrid route?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add vector search timing and I/O diagnostics [paimon-rust]
Posted by "shyjsarah (via GitHub)" <gi...@apache.org>.
shyjsarah commented on PR #711:
URL: https://github.com/apache/paimon-rust/pull/711#issuecomment-5312536048
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org