[GitHub] [lucene] uschindler commented on pull request #11806: GITHUB#11728: Add a InterruptedCollector to received thread interrupt request and exit search task early

[GitBox <gi...@apache.org>]

uschindler commented on PR #11806:
URL: https://github.com/apache/lucene/pull/11806#issuecomment-1257216396

   This won't work when the thread is blocked on I/O (e.g. when it reads from IndexInput). Java has the behaviour to close file handles for safety when a thread doing IO was interrupted. When you use this collector the file handle might get closed.
   This won't negatively affect MMapDirectory (unless you interrupt at the time of opening the file), but all other implementations will fail.
   So we won't merge this. See also @rmuir 's comment in #11728.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org