You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Aidan Skinner <ai...@apache.org> on 2008/10/07 16:56:30 UTC
Re: svn commit: r702488 - in /incubator/qpid/trunk/qpid/java/client/src: main/java/org/apache/qpid/client/AMQBrokerDetails.java main/java/org/apache/qpid/jms/BrokerDetails.java test/java/org/apache/qpid/test/unit/client/BrokerDetails/BrokerDetailsTes
On Tue, Oct 7, 2008 at 3:10 PM, <ra...@apache.org> wrote:
> Author: rajith
> Date: Tue Oct 7 07:10:39 2008
> New Revision: 702488
>
> URL: http://svn.apache.org/viewvc?rev=702488&view=rev
> Log:
> This is a fix for QPID-1319.
>
Who reviewed this? I can't see any comments on the Jira.
- Aidan
--
Apache Qpid - World Domination through Advanced Message Queueing
http://cwiki.apache.org/qpid
"Nine-tenths of wisdom consists in being wise in time." - Theodore Roosevelt
Re: svn commit: r702488 - in /incubator/qpid/trunk/qpid/java/client/src: main/java/org/apache/qpid/client/AMQBrokerDetails.java main/java/org/apache/qpid/jms/BrokerDetails.java test/java/org/apache/qpid/test/unit/client/BrokerDetails/BrokerDetailsTes
Posted by Aidan Skinner <ai...@apache.org>.
On Tue, Oct 7, 2008 at 4:08 PM, Rajith Attapattu <ra...@gmail.com> wrote:
> I thought we have moved to a commit then review model.
> However I have incorrectly marked the JIRA as resolved, instead of marking
> it as up for review.Regards,
That's where the confusion came in. I saw the commit, I saw the Jira was
resolved but I couldn't see who reviewed it or when.
> Btw, could you please do the honors by reviewing it?
>
Change it to the right state and assign it to me and I'll take a look when
I'm in review-mode.
- Aidan
--
Apache Qpid - World Domination through Advanced Message Queueing
http://cwiki.apache.org/qpid
"Nine-tenths of wisdom consists in being wise in time." - Theodore Roosevelt
Re: svn commit: r702488 - in /incubator/qpid/trunk/qpid/java/client/src: main/java/org/apache/qpid/client/AMQBrokerDetails.java main/java/org/apache/qpid/jms/BrokerDetails.java test/java/org/apache/qpid/test/unit/client/BrokerDetails/BrokerDetailsTes
Posted by Rajith Attapattu <ra...@gmail.com>.
I thought we have moved to a commit then review model.
However I have incorrectly marked the JIRA as resolved, instead of marking
it as up for review.Regards,
Btw, could you please do the honors by reviewing it?
Rajith.
On Tue, Oct 7, 2008 at 10:56 AM, Aidan Skinner <ai...@apache.org> wrote:
> On Tue, Oct 7, 2008 at 3:10 PM, <ra...@apache.org> wrote:
>
>
> > Author: rajith
> > Date: Tue Oct 7 07:10:39 2008
> > New Revision: 702488
> >
> > URL: http://svn.apache.org/viewvc?rev=702488&view=rev
> > Log:
> > This is a fix for QPID-1319.
> >
>
> Who reviewed this? I can't see any comments on the Jira.
>
> - Aidan
> --
> Apache Qpid - World Domination through Advanced Message Queueing
> http://cwiki.apache.org/qpid
> "Nine-tenths of wisdom consists in being wise in time." - Theodore
> Roosevelt
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/