You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/09 04:15:07 UTC

[GitHub] [incubator-kvrocks-website] segment11 opened a new pull request, #20: 1. add default data directory volume mount for using docker.

segment11 opened a new pull request, #20:
URL: https://github.com/apache/incubator-kvrocks-website/pull/20

   So the new user could easily understand before read kvrocks.conf


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] PragmaTwice merged pull request #20: Add default data directory volume mount for using docker

Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #20:
URL: https://github.com/apache/incubator-kvrocks-website/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] tisonkun commented on a diff in pull request #20: 1. add default data directory volume mount for using docker.

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #20:
URL: https://github.com/apache/incubator-kvrocks-website/pull/20#discussion_r1017423956


##########
docs/02-server-installation.md:
##########
@@ -6,7 +6,7 @@ For installing docker, follow the Docker installation instructions found here: h
 Start the kvrocks service:
 
 ```shell
-$ docker run -it -p 6666:6666 kvrocks/kvrocks
+$ docker run -it -p 6666:6666 -v /var/lib/kvrocks:/var/lib/kvrocks kvrocks/kvrocks

Review Comment:
   ```suggestion
   $ docker run -it -p 6666:6666 -v /var/lib/kvrocks:/var/lib/kvrocks apache/kvrocks
   ```
   
   Also update image url and I think this may be an enhancement to Kvrocks - that is, we support docker run with some configure instead of modifying in place at Dockerfile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org