You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/04 11:38:34 UTC
[GitHub] [incubator-kvrocks] tanruixiang opened a new pull request, #1075: Fix part of the clang-tidy warning
tanruixiang opened a new pull request, #1075:
URL: https://github.com/apache/incubator-kvrocks/pull/1075
Related to #1029 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1075: Fix part of the clang-tidy warning
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1075:
URL: https://github.com/apache/incubator-kvrocks/pull/1075#issuecomment-1303809238
> > Looks good to me.
> > I just wonder if there is any check whose reports in kvrocks are all fixed. And then we can put them in `.clang-tidy`, according to #1029.
>
> I am fixing them in file order. I will try to see which checks have been fully fixed when I have time.
Got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1075: Fix part of the clang-tidy warning
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #1075:
URL: https://github.com/apache/incubator-kvrocks/pull/1075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on pull request #1075: Fix part of the clang-tidy warning
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on PR #1075:
URL: https://github.com/apache/incubator-kvrocks/pull/1075#issuecomment-1303785558
> Looks good to me.
>
> I just wonder if there is any check whose reports in kvrocks are all fixed. And then we can put them in `.clang-tidy`, according to #1029.
I am fixing them in file order. I will try to see which checks have been fully fixed when I have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org