You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2020/12/02 23:27:40 UTC

[GitHub] [mesos] bmahler commented on pull request #371: [MESOS-10199] Fix Host field in client headers

bmahler commented on pull request #371:
URL: https://github.com/apache/mesos/pull/371#issuecomment-737557425


   Thanks for fixing this, a couple of things, maybe @vinodkone or @asekretenko can have a look after these updates:
   
   * Can you follow the existing logic for the http client?  See: https://github.com/apache/mesos/blob/1.11.0/3rdparty/libprocess/src/http.cpp#L1092-L1108
   * Can you remove the extra .gitignore file? It's not related to this change and we like to keep our commits tidy with only a single logical change involved
   * Can you add or update one of the existing tests in libprocess?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org