You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/30 15:13:14 UTC
[GitHub] [pulsar] sbourkeostk opened a new pull request #6172: [Issue #6171]
Fix Python function launcher
sbourkeostk opened a new pull request #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172
Fixes #6171
### Motivation
Cope with extra arg added to Python pulsar.Client class in #6113
### Modifications
Make args to pulsar.Client explicit in python_instance_main
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why?
minor bugfix
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sbourkeostk opened a new pull request #6172: [Issue #6171]
Fix Python function launcher
Posted by GitBox <gi...@apache.org>.
sbourkeostk opened a new pull request #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172
Fixes #6171
### Motivation
Cope with extra arg added to Python pulsar.Client class in #6113
### Modifications
Make args to pulsar.Client explicit in python_instance_main
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why?
minor bugfix
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6172: [Issue #6171] Fix Python
function launcher
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172#issuecomment-580651110
I think this change doesn't address the problem yet. the pulsar function still can't run it correctly. so I am reverting the change #6113 in #6174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sbourkeostk closed pull request #6172: [Issue #6171] Fix
Python function launcher
Posted by GitBox <gi...@apache.org>.
sbourkeostk closed pull request #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sbourkeostk closed pull request #6172: [Issue #6171] Fix
Python function launcher
Posted by GitBox <gi...@apache.org>.
sbourkeostk closed pull request #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sbourkeostk commented on issue #6172: [Issue #6171] Fix
Python function launcher
Posted by GitBox <gi...@apache.org>.
sbourkeostk commented on issue #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172#issuecomment-580747077
I see what you mean. When I first modified `python_instance_main.py` I added a `None` to the args list. Then I redid it with named args but I think I must have got my docker images mixed when I tested the second version out. I'll resubmit this shortly. It just needs
```tls_trust_cert_path=tls_trust_cert_path``` -> ```tls_trust_certs_file_path=tls_trust_cert_path```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sbourkeostk commented on issue #6172: [Issue #6171] Fix
Python function launcher
Posted by GitBox <gi...@apache.org>.
sbourkeostk commented on issue #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172#issuecomment-580930690
I'll take your word for it :-) For what it's worth, Python functions do work for me in practice with this PR but I'm not using the new logger feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6172: [Issue #6171] Fix Python
function launcher
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172#issuecomment-580838676
@sbourkeostk I don't think it works. https://github.com/apache/pulsar/pull/6172/checks?check_run_id=419420571 the python function still doesn't work. I think it is something related to the way the logger was handled. In #6174, this integration test can pass. https://github.com/apache/pulsar/pull/6174/checks?check_run_id=418897136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sbourkeostk commented on issue #6172: [Issue #6171] Fix
Python function launcher
Posted by GitBox <gi...@apache.org>.
sbourkeostk commented on issue #6172: [Issue #6171] Fix Python function launcher
URL: https://github.com/apache/pulsar/pull/6172#issuecomment-580763588
Ok, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services