[GitHub] [incubator-mxnet] vandanavk commented on a change in pull request #14491: Enable slice embedding concat split fuse

[GitBox <gi...@apache.org>]

vandanavk commented on a change in pull request #14491: Enable slice embedding concat split fuse
URL: https://github.com/apache/incubator-mxnet/pull/14491#discussion_r282766149
 
 

 ##########
 File path: src/operator/slice_channel-inl.h
 ##########
 @@ -146,7 +146,75 @@ class SliceChannelOp : public Operator {
 
 template<typename xpu>
 Operator *CreateOp(SliceChannelParam param, int dtype);
-
+inline bool SliceChannelInferShape(mxnet::ShapeVector *in_shape,
+    mxnet::ShapeVector *out_shape,
+    mxnet::ShapeVector *aux_shape,
+    int num_outputs, int axis, bool squeeze_axis) {
+    using namespace mshadow;
+    CHECK_EQ(in_shape->size(), 1U);
+    mxnet::TShape dshape = in_shape->at(slice_enum::kData);
+    mxnet::TShape ishape = in_shape->at(slice_enum::kData);
 
 Review comment:
   does in_shape->at have to accessed twice? can we do it once and reuse?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services