You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ch...@apache.org on 2018/10/31 18:28:23 UTC
[mesos] 05/06: Fixed outdated comments for mocking the secret
generator.
This is an automated email from the ASF dual-hosted git repository.
chhsiao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 6448d82bfea4398456e5b5cb744288f28077ca96
Author: Chun-Hung Hsiao <ch...@apache.org>
AuthorDate: Wed Oct 31 11:16:52 2018 -0700
Fixed outdated comments for mocking the secret generator.
Review: https://reviews.apache.org/r/68806/
---
src/tests/cluster.cpp | 2 +-
src/tests/slave_authorization_tests.cpp | 1 -
src/tests/slave_tests.cpp | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/tests/cluster.cpp b/src/tests/cluster.cpp
index a7226c7..2b351ca 100644
--- a/src/tests/cluster.cpp
+++ b/src/tests/cluster.cpp
@@ -535,7 +535,7 @@ Try<process::Owned<Slave>> Slave::create(
slave->qosController.reset(_qosController.get());
}
- // If the QoS controller is not provided, create a default one.
+ // If the secret generator is not provided, create a default one.
if (secretGenerator.isNone()) {
SecretGenerator* _secretGenerator = nullptr;
diff --git a/src/tests/slave_authorization_tests.cpp b/src/tests/slave_authorization_tests.cpp
index 061e230..efd2248 100644
--- a/src/tests/slave_authorization_tests.cpp
+++ b/src/tests/slave_authorization_tests.cpp
@@ -801,7 +801,6 @@ TEST_F(ExecutorAuthorizationTest, FailedSubscribe)
Owned<TestContainerizer> containerizer(
new TestContainerizer(devolve(executorInfo.executor_id()), executor));
- // This pointer is passed to the agent, which will perform the cleanup.
Owned<MockSecretGenerator> mockSecretGenerator(new MockSecretGenerator());
Try<Owned<cluster::Slave>> slave = StartSlave(
diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp
index 637bedc..1e91871 100644
--- a/src/tests/slave_tests.cpp
+++ b/src/tests/slave_tests.cpp
@@ -7847,7 +7847,6 @@ TEST_F(SlaveTest, RunTaskGroupFailedSecretGeneration)
StandaloneMasterDetector detector(master.get()->pid);
- // This pointer is passed to the agent, which will perform the cleanup.
Owned<MockSecretGenerator> secretGenerator(new MockSecretGenerator());
Try<Owned<cluster::Slave>> slave = StartSlave(