You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/10 16:53:55 UTC

[GitHub] [arrow] kiszk opened a new pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in big-endian format

kiszk opened a new pull request #7146:
URL: https://github.com/apache/arrow/pull/7146


   This PR writes and reads Plasma header (version, type, and length) in the big-endian format. It allows us to make it easy to interpret a header of Plasma data among different endian machines.
   
   The current issue is to write Plasma header in native endian at [here](https://github.com/apache/arrow/blob/master/cpp/src/plasma/io.cc#L65-L71). It is not possible to know version, type, and length among different platforms. Feather V2 also uses little-endian for the header based on [the discussion](https://github.com/apache/arrow/pull/6777#discussion_r400770040).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

Posted by GitBox <gi...@apache.org>.
kou closed pull request #7146:
URL: https://github.com/apache/arrow/pull/7146


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7146:
URL: https://github.com/apache/arrow/pull/7146#issuecomment-629374066


   Sorry, auto-rebase didn't work because there are changes to .github/workflows in master. IDK if the "C GLib & Ruby / AMD64 Windows MinGW 64 GLib & Ruby" failure is real or not, or if rebase would fix it, but that's what I was trying. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7146:
URL: https://github.com/apache/arrow/pull/7146#issuecomment-626418016


   Good catch. updated the title.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in big-endian format

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7146:
URL: https://github.com/apache/arrow/pull/7146#issuecomment-626358208


   https://issues.apache.org/jira/browse/ARROW-8757


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7146:
URL: https://github.com/apache/arrow/pull/7146#issuecomment-629370089


   @github-actions rebase


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7146:
URL: https://github.com/apache/arrow/pull/7146#issuecomment-629530281


   Rerunning fixed the test failure.
   I've merged this.
   Sorry. I forgot to merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org