You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/27 02:42:17 UTC

[GitHub] [cloudstack-go] pdion891 opened a new pull request #5: fix #4: only work on 4.15

pdion891 opened a new pull request #5:
URL: https://github.com/apache/cloudstack-go/pull/5


   This PR fix the HostService failing json parsing, but only for  CloudStack 4.15. 
   
   Prior to acs 4.15, `Managementserverid` was an integer as ID.  help would be required on how to convert the API response or we create branch of this repo depending on the CloudStack version ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-go] rhtyd merged pull request #5: fix #4: only work on 4.15

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5:
URL: https://github.com/apache/cloudstack-go/pull/5


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-go] rhtyd commented on pull request #5: fix #4: only work on 4.15

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5:
URL: https://github.com/apache/cloudstack-go/pull/5#issuecomment-907142122


   @pdion891 Yes you're right, maybe we should tag releases based on ACS versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-go] pdion891 commented on pull request #5: fix #4: only work on 4.15

Posted by GitBox <gi...@apache.org>.
pdion891 commented on pull request #5:
URL: https://github.com/apache/cloudstack-go/pull/5#issuecomment-907138389


   @rhtyd  if this SDK must match the acs version because of the API list, shouldn't it be easier to use the same version as ACS for this SDK version. 
   ie, creating version of this SDK v4.15-x, increment last digit for SDX fixes.
   
   That way it would be easy to know which version of the SDX fit with the running version of ACS ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack-go] rhtyd commented on pull request #5: fix #4: only work on 4.15

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5:
URL: https://github.com/apache/cloudstack-go/pull/5#issuecomment-906972660


   @pdion891 generally for every release we have to update this sdk based on list APIs json file and auto-generate the codebase. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org