You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/20 01:28:05 UTC
[GitHub] [helix] jiajunwang opened a new issue #767: Assignment metadata missing for the WAGED rebalancer in stress test.
jiajunwang opened a new issue #767:
URL: https://github.com/apache/helix/issues/767
Please see the attachment, the baseline node is empty. I observed this multiple times in the stress test.
I suspect this is about the GC thread.
1. ZkBucketDataAccessor.GC_THREAD should be created as a single thread pool instead of creating by newScheduledThreadPool() which could have more threads.
2. To ensure the order of the clean tasks, we'd better leverage a queue instead of relying on the TTL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #767: Assignment metadata missing for the WAGED rebalancer in stress test.
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #767:
URL: https://github.com/apache/helix/issues/767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #767: Assignment metadata missing for the WAGED rebalancer in stress test.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #767:
URL: https://github.com/apache/helix/issues/767#issuecomment-646915788
There is another concurrent modification issue found.
1. Regular GC task fails due to concurrent list modification and the stale versions are not removed at all.
2. If, by coincident, there is newer version in the list other then the current version, then because of the modification of the list inside the loop, the final element (the newer version) won't be filtered but being left in the to-be-removed list. Then the GC task removes the most recent version. For example,
a) Input, current version "2"
b) Children = [1, 2, 3]
c) The task avoids checking "2", so the list for loop is: [1, 3]
d) When check "1", it is removed from the list. So the list becomes [3]. Then the loop ends, because the first item has already been looped from the for iteration perspective.
e) The version to be removed is "3"!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org