You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/04/19 17:35:05 UTC
[GitHub] [beam] bvolpato opened a new pull request, #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker
bvolpato opened a new pull request, #26352:
URL: https://github.com/apache/beam/pull/26352
Adding HasProgress and implementing a naive progress tracker at BoundedSourceAsSDFRestrictionTracker.
This is currently causing slowness on Dataflow Worker. That wrapper doesn't implement it and 0 is implied, so autoscaling and splitting doesn't work as expected.
Fixes https://github.com/apache/beam/issues/26338
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] ~Update `CHANGES.md` with noteworthy changes.~
- [ ] ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on a diff in pull request #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker
Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #26352:
URL: https://github.com/apache/beam/pull/26352#discussion_r1171803125
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java:
##########
@@ -442,6 +443,19 @@ public void checkDone() throws IllegalStateException {
public IsBounded isBounded() {
return IsBounded.BOUNDED;
}
+
+ @Override
+ public Progress getProgress() {
+ if (currentReader == null) {
+ return null;
Review Comment:
We've replaced with Progress.NONE as a placeholder for this (0 work done, 1 remaining)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26352:
URL: https://github.com/apache/beam/pull/26352#issuecomment-1515157014
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #26352:
URL: https://github.com/apache/beam/pull/26352#discussion_r1171724685
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java:
##########
@@ -442,6 +443,19 @@ public void checkDone() throws IllegalStateException {
public IsBounded isBounded() {
return IsBounded.BOUNDED;
}
+
+ @Override
+ public Progress getProgress() {
+ if (currentReader == null) {
+ return null;
Review Comment:
Noting that the return value is not `@Nullable`. Suggest re-enabling nullness checking here since it would have caught this. (you could perhaps suppress it for other parts of the file you don't want to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26352:
URL: https://github.com/apache/beam/pull/26352#issuecomment-1515162952
Run Java_Pulsar_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #26352: Implement naive progress tracking at BoundedSourceAsSDFRestrictionTracker
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj merged PR #26352:
URL: https://github.com/apache/beam/pull/26352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org