You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/01/02 15:39:37 UTC
Review Request 64888: Added check for handling of checkpointed
resources in reregistration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8350
https://issues.apache.org/jira/browse/MESOS-8350
Repository: mesos
Description
-------
This patch adds a check that confirms that the master resends
checkpointed resources to the agent on reregistration.
Diffs
-----
src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8
Diff: https://reviews.apache.org/r/64888/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64888: Added test of handling of checkpointed
resources in reregistration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/
-----------------------------------------------------------
(Updated Jan. 4, 2018, 11:06 a.m.)
Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed comments from Jie.
Summary (updated)
-----------------
Added test of handling of checkpointed resources in reregistration.
Bugs: MESOS-8350
https://issues.apache.org/jira/browse/MESOS-8350
Repository: mesos
Description (updated)
-------
This patch adds a test that confirms that the master resends
checkpointed resources to the agent on reregistration.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 387c2ff62d3ccfe918775b5c059eafb9d4fa8d87
Diff: https://reviews.apache.org/r/64888/diff/3/
Changes: https://reviews.apache.org/r/64888/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64888: Added check for handling of checkpointed
resources in reregistration.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/#review194701
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/slave_recovery_tests.cpp
Lines 4784 (patched)
<https://reviews.apache.org/r/64888/#comment273637>
s/not/non/
- Jie Yu
On Jan. 2, 2018, 5:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64888/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2018, 5:27 p.m.)
>
>
> Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8350
> https://issues.apache.org/jira/browse/MESOS-8350
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a check that confirms that the master resends
> checkpointed resources to the agent on reregistration.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8
>
>
> Diff: https://reviews.apache.org/r/64888/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64888: Added check for handling of checkpointed
resources in reregistration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/#review194691
-----------------------------------------------------------
Ship it!
The patch itself looks good, but you should replace 'check' with 'test' in the commit message.
- Benno Evers
On Jan. 2, 2018, 5:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64888/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2018, 5:27 p.m.)
>
>
> Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8350
> https://issues.apache.org/jira/browse/MESOS-8350
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a check that confirms that the master resends
> checkpointed resources to the agent on reregistration.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8
>
>
> Diff: https://reviews.apache.org/r/64888/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64888: Added check for handling of checkpointed
resources in reregistration.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/#review194704
-----------------------------------------------------------
src/tests/slave_recovery_tests.cpp
Lines 4873 (patched)
<https://reviews.apache.org/r/64888/#comment273640>
Do you need this?
- Jie Yu
On Jan. 2, 2018, 5:27 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64888/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2018, 5:27 p.m.)
>
>
> Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8350
> https://issues.apache.org/jira/browse/MESOS-8350
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a check that confirms that the master resends
> checkpointed resources to the agent on reregistration.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8
>
>
> Diff: https://reviews.apache.org/r/64888/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64888: Added check for handling of checkpointed
resources in reregistration.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/
-----------------------------------------------------------
(Updated Jan. 2, 2018, 6:27 p.m.)
Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8350
https://issues.apache.org/jira/browse/MESOS-8350
Repository: mesos
Description
-------
This patch adds a check that confirms that the master resends
checkpointed resources to the agent on reregistration.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8
Diff: https://reviews.apache.org/r/64888/diff/2/
Changes: https://reviews.apache.org/r/64888/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier