You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/14 17:15:27 UTC

[GitHub] [airflow] SPTKL opened a new issue, #26399: GKEHook.create_cluster is not wait_for_operation using the input project_id parameter

SPTKL opened a new issue, #26399:
URL: https://github.com/apache/airflow/issues/26399

   ### Apache Airflow version
   
   main (development)
   
   ### What happened
   
   In the GKEHook, the `create_cluster` method is creating a GKE cluster in the project_id specified by the input, but in `wait_for_operation`, it's waiting for the operation to appear in the default project_id
   https://github.com/apache/airflow/blob/f6c579c1c0efb8cdd2eaf905909cda7bc7314f88/airflow/providers/google/cloud/hooks/kubernetes_engine.py#L231-L237
   this throws a bug when we are trying to create clusters under different project_id (compared to the default project_id)
   
   ### What you think should happen instead
   
   instead it should be
   ```python
   resource = self.wait_for_operation(resource, project_id)
   ```
   so that we won't get errors when trying to create a cluster under a different project_id
   
   ### How to reproduce
   
   ```python
   create_cluster = GKECreateClusterOperator(
           task_id="create_cluster",
           project_id=GCP_PROJECT_ID,
           location=GCP_LOCATION,
           body=CLUSTER,
       )
   ```
   and make sure the GCP_PROJECT_ID is not the same as the default project_id used by the default google service account
   
   
   ### Operating System
   
   Linux
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Composer
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #26399: GKEHook.create_cluster is not wait_for_operation using the input project_id parameter

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #26399: GKEHook.create_cluster is not wait_for_operation using the input project_id parameter
URL: https://github.com/apache/airflow/issues/26399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #26399: GKEHook.create_cluster is not wait_for_operation using the input project_id parameter

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #26399:
URL: https://github.com/apache/airflow/issues/26399#issuecomment-1247071917

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org