You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/15 15:04:20 UTC

[jira] [Commented] (FLINK-4550) Clearly define SQL operator table

    [ https://issues.apache.org/jira/browse/FLINK-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493575#comment-15493575 ] 

ASF GitHub Bot commented on FLINK-4550:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2502

    [FLINK-4550] [table] Clearly define SQL operator table

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR reduces the number of SQL operators to those that are fully supported. Since the SQL validator know which functions/operations are supported, this PR should also reduce the number of exceptions in code generation etc.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4550

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2502
    
----
commit 1790235551cd54a3b5f7c7b38c251f0af8d2ce76
Author: twalthr <tw...@apache.org>
Date:   2016-09-15T14:56:16Z

    [FLINK-4550] [table] Clearly define SQL operator table

----


> Clearly define SQL operator table
> ---------------------------------
>
>                 Key: FLINK-4550
>                 URL: https://issues.apache.org/jira/browse/FLINK-4550
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>              Labels: starter
>
> Currently, we use {{SqlStdOperatorTable.instance()}} for setting all supported operations. However, not all of them are actually supported. {{FunctionCatalog}} should only return those operators that are tested and documented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)