You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/08/20 15:52:38 UTC
[jira] [Updated] (DERBY-5359) Missing xmlns attribute for html
element in docs
[ https://issues.apache.org/jira/browse/DERBY-5359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-5359:
--------------------------------------
Attachment: xmlns.diff
I thought I'd pick up the remaining tasks in this issue (that is, the table of contents and the topics) since there hasn't been any activity for some time.
I first tried to add an xmlns attribute to the <xsl:stylesheet> tag in lib/map2htmtoc.xsl and lib/dita2htmlImpl.xsl. This did make the resulting xhtml files include an xmlns attribute in the <html> tag, and the fix was sufficient for the table of contents. However, with the topics, I ran into the same problem that Kim observed in DERBY-4408, with some other tags being output with xmlns="".
That problem is caused by dita2htmlImpl.xsl including some other XSL files, which also lack the xmlns attribute and need a similar fix. We haven't yet copied those files from DITA-OT to the lib directory. Instead of checking in modified copies of those files in the subversion repository, I made the Ant script make the changes before the docs are built using the ReplaceRegExp task. See the attached patch xmlns.diff.
I built the reference manual using the patch and diffed the resulting html files against html files built from a clean trunk, and verified that adding an xmlns attribute to the <html> tag was the only change. I also ran a random selection of html files through http://validator.w3.org and they all passed as valid XHTML now. Finally, I browsed the new version of the reference manual using Firefox, Chrome and Internet Explorer without finding any problems.
> Missing xmlns attribute for html element in docs
> ------------------------------------------------
>
> Key: DERBY-5359
> URL: https://issues.apache.org/jira/browse/DERBY-5359
> Project: Derby
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 10.9.1.0
> Reporter: Knut Anders Hatlen
> Assignee: Jayaram Subramanian
> Attachments: derby5359.diff, derby5359-ref.diff, derby5359-ref-stat.txt, files-derby5359.zip, html.zip, xmlns.diff
>
>
> The html files in the documentation that are declared as XHTML don't pass as valid XHTML because the html elements lack the xmlns attribute. Examples:
> http://db.apache.org/derby/docs/dev/ref/index.html
> --> http://validator.w3.org/check?uri=http%3A%2F%2Fdb.apache.org%2Fderby%2Fdocs%2Fdev%2Fref%2Findex.html
> http://db.apache.org/derby/docs/dev/ref/toc.html
> --> http://validator.w3.org/check?uri=http%3A%2F%2Fdb.apache.org%2Fderby%2Fdocs%2Fdev%2Fref%2Ftoc.html
> http://db.apache.org/derby/docs/dev/ref/rrefcallprocedure.html
> --> http://validator.w3.org/check?uri=http%3A%2F%2Fdb.apache.org%2Fderby%2Fdocs%2Fdev%2Fref%2Frrefcallprocedure.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira