You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by er...@apache.org on 2015/03/03 05:57:59 UTC
svn commit: r1663527 - in /lucene/dev/branches/branch_5x/solr: ./
CHANGES.txt core/
core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java
Author: erick
Date: Tue Mar 3 04:57:59 2015
New Revision: 1663527
URL: http://svn.apache.org/r1663527
Log:
SOLR-6657: DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't
Modified:
lucene/dev/branches/branch_5x/solr/ (props changed)
lucene/dev/branches/branch_5x/solr/CHANGES.txt (contents, props changed)
lucene/dev/branches/branch_5x/solr/core/ (props changed)
lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java
Modified: lucene/dev/branches/branch_5x/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_5x/solr/CHANGES.txt?rev=1663527&r1=1663526&r2=1663527&view=diff
==============================================================================
--- lucene/dev/branches/branch_5x/solr/CHANGES.txt (original)
+++ lucene/dev/branches/branch_5x/solr/CHANGES.txt Tue Mar 3 04:57:59 2015
@@ -127,6 +127,9 @@ Bug Fixes
* SOLR-7171: BaseDistributedSearchTestCase now clones getSolrHome() for each subclass,
and consistently uses getSolrXml(). (hossman)
+* SOLR-6657: DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't
+ (Erick Erickson)
+
Optimizations
----------------------
Modified: lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java?rev=1663527&r1=1663526&r2=1663527&view=diff
==============================================================================
--- lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java (original)
+++ lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java Tue Mar 3 04:57:59 2015
@@ -46,10 +46,7 @@ public class DocumentDictionaryFactory e
if (field == null) {
throw new IllegalArgumentException(FIELD + " is a mandatory parameter");
}
- if (weightField == null) {
- throw new IllegalArgumentException(WEIGHT_FIELD + " is a mandatory parameter");
- }
-
+
return new DocumentDictionary(searcher.getIndexReader(), field, weightField, payloadField);
}