You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by madrob <gi...@git.apache.org> on 2014/08/20 16:16:24 UTC
[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...
GitHub user madrob opened a pull request:
https://github.com/apache/curator/pull/39
CURATOR-136 Make LeaderLatch handling of relative paths consistent.
LeaderLatch would previously normalize a relative path in some places
but not others, causing inconsistent behavior. Make it check for an
absolute path on startup.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madrob/curator CURATOR-136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 0f598860e78dd4796eb8af8cfcc370952258bded
Author: Mike Drob <md...@cloudera.com>
Date: 2014-08-11T20:12:53Z
CURATOR-136 Make LeaderLatch handling of relative paths consistent.
LeaderLatch would previously normalize a relative path in some places
but not others, causing inconsistent behavior. Make it check for an
absolute path on startup.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/39#issuecomment-52797299
If you don't mind, this type of change should be applied to all the recipes, don't you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/39#issuecomment-52844699
New code pushed, incorporating feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/39#issuecomment-52835862
I think each recipe should do it, yes. If possible, it could be abstracted into a single method of some kind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/39#issuecomment-52797577
I looked through them and didn't see any that wouldn't fail fast due to delegated checks in the constructors. Very possible that I missed some, though.
Were you thinking that you want an explicit check in each recipe instead of relying on the underlying client behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---