[GitHub] [storm] srdo commented on issue #3132: STORM-3186: Customizable configuration for metric reporting interval

[GitBox <gi...@apache.org>]

srdo commented on issue #3132: STORM-3186: Customizable configuration for metric reporting interval
URL: https://github.com/apache/storm/pull/3132#issuecomment-536050847
 
 
   I think the ScheduledStormReporter classes are for the metrics reporters for the workers (the parts topologies can hook into), while this is for the daemons. I think having separate parameters makes sense, as the worker metrics config is topology level, while this new setting is at the cluster level.
   
   Don't have an opinion on whether we should add a parameter for setting the time unit as well, do you think it would be useful?
   
   As an aside, we really should rename StormMetricsRegistry. We have StormMetricRegistry for the workers, and StormMetricsRegistry for the daemons. It's easy to mix them up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services