You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/03/29 21:35:08 UTC
[kudu-CR] [examples] Add licenses to Python examples
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9858
Change subject: [examples] Add licenses to Python examples
......................................................................
[examples] Add licenses to Python examples
This also adds a README to the graphite example warning that it's
not a real integration, just an example.
Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
---
M examples/python/dstat-kudu/README.md
M examples/python/dstat-kudu/kudu_dstat.py
A examples/python/graphite-kudu/README.adoc
M examples/python/graphite-kudu/kudu/__init__.py
M examples/python/graphite-kudu/kudu/kudu_graphite.py
M examples/python/graphite-kudu/setup.py
M python/setup.cfg
7 files changed, 108 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/9858/1
--
To view, visit http://gerrit.cloudera.org:8080/9858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] Add licenses to Python examples
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9858 )
Change subject: [examples] Add licenses to Python examples
......................................................................
[examples] Add licenses to Python examples
This also adds a README to the graphite example warning that it's
not a real integration, just an example.
Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Reviewed-on: http://gerrit.cloudera.org:8080/9858
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M examples/python/dstat-kudu/README.md
M examples/python/dstat-kudu/kudu_dstat.py
A examples/python/graphite-kudu/README.adoc
M examples/python/graphite-kudu/kudu/__init__.py
M examples/python/graphite-kudu/kudu/kudu_graphite.py
M examples/python/graphite-kudu/setup.py
M python/setup.cfg
7 files changed, 108 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [examples] Add licenses to Python examples
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9858 )
Change subject: [examples] Add licenses to Python examples
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 03:08:05 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] Add licenses to Python examples
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9858 )
Change subject: [examples] Add licenses to Python examples
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9858/1/examples/python/graphite-kudu/README.adoc
File examples/python/graphite-kudu/README.adoc:
http://gerrit.cloudera.org:8080/#/c/9858/1/examples/python/graphite-kudu/README.adoc@22
PS1, Line 22: is
drop
http://gerrit.cloudera.org:8080/#/c/9858/1/examples/python/graphite-kudu/README.adoc@23
PS1, Line 23: a
an
--
To view, visit http://gerrit.cloudera.org:8080/9858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 29 Mar 2018 23:54:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] Add licenses to Python examples
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9858 )
Change subject: [examples] Add licenses to Python examples
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9858/1/examples/python/graphite-kudu/README.adoc
File examples/python/graphite-kudu/README.adoc:
http://gerrit.cloudera.org:8080/#/c/9858/1/examples/python/graphite-kudu/README.adoc@22
PS1, Line 22: is
> drop
Done
http://gerrit.cloudera.org:8080/#/c/9858/1/examples/python/graphite-kudu/README.adoc@23
PS1, Line 23: a
> an
Done
--
To view, visit http://gerrit.cloudera.org:8080/9858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sun, 01 Apr 2018 22:33:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] Add licenses to Python examples
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9858
to look at the new patch set (#2).
Change subject: [examples] Add licenses to Python examples
......................................................................
[examples] Add licenses to Python examples
This also adds a README to the graphite example warning that it's
not a real integration, just an example.
Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
---
M examples/python/dstat-kudu/README.md
M examples/python/dstat-kudu/kudu_dstat.py
A examples/python/graphite-kudu/README.adoc
M examples/python/graphite-kudu/kudu/__init__.py
M examples/python/graphite-kudu/kudu/kudu_graphite.py
M examples/python/graphite-kudu/setup.py
M python/setup.cfg
7 files changed, 108 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/9858/2
--
To view, visit http://gerrit.cloudera.org:8080/9858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8825bfac0416fc19fdb99c972eb104898ba78e7d
Gerrit-Change-Number: 9858
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>