You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/06/11 14:27:23 UTC

[GitHub] [doris] morningman commented on a diff in pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules

morningman commented on code in PR #20185:
URL: https://github.com/apache/doris/pull/20185#discussion_r1225827444


##########
fe/be-java-extensions/paimon-scanner/pom.xml:
##########
@@ -0,0 +1,83 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>be-java-extensions</artifactId>
+        <groupId>org.apache.doris</groupId>
+        <version>${revision}</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>paimon-scanner</artifactId>
+
+    <properties>
+        <maven.compiler.source>8</maven.compiler.source>
+        <maven.compiler.target>8</maven.compiler.target>
+        <paimon.version>0.4-SNAPSHOT</paimon.version>

Review Comment:
   change to `0.4.0-incubating`



##########
fe/be-java-extensions/hudi-scanner/src/main/java/org/apache/doris/hudi/Utils.java:
##########
@@ -15,9 +15,9 @@
 // specific language governing permissions and limitations
 // under the License.
 
-package org.apache.doris.jni.utils;
+package org.apache.doris.hudi;
 
-import org.apache.commons.io.FileUtils;
+import com.facebook.presto.hadoop.$internal.org.apache.commons.io.FileUtils;

Review Comment:
   Why changing to this?



##########
fe/pom.xml:
##########
@@ -263,16 +263,24 @@ under the License.
         <RoaringBitmap.version>0.8.13</RoaringBitmap.version>
         <spark.version>2.4.6</spark.version>
         <hive.version>3.1.3</hive.version>
+        <hive.common.version>2.3.9</hive.common.version>
+        <mapreduce.client.version>2.10.1</mapreduce.client.version>
         <calcite.version>1.33.0</calcite.version>
         <avatica.version>1.22.0</avatica.version>
         <!-- ATTN: avro version must be consistent with Iceberg version -->
         <!-- Please modify iceberg.version and avro.version together,
          you can find avro version info in iceberg mvn repository -->
         <iceberg.version>1.1.0</iceberg.version>
         <maxcompute.version>0.43.3-public</maxcompute.version>
+        <arrow.version>9.0.0</arrow.version>
         <avro.version>1.11.1</avro.version>
         <!-- hudi -->
         <hudi.version>0.13.0</hudi.version>
+        <presto.hadoop.version>2.7.4-11</presto.hadoop.version>
+        <presto.hive.version>3.0.0-8</presto.hive.version>
+        <!-- hudi be scan version TODO Verify compatibility -->
+        <hudi.scan.version>0.12.2</hudi.scan.version>

Review Comment:
   should be 0.13?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org