You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/03 10:08:50 UTC
[GitHub] [spark] NarekDW opened a new pull request, #38895: [MINOR][SQL] Get rid of redundant type cast
NarekDW opened a new pull request, #38895:
URL: https://github.com/apache/spark/pull/38895
### What changes were proposed in this pull request?
A minor change to fix the compilation warning
`/spark/sql/hive/src/main/java/org/apache/hadoop/hive/ql/io/DelegateSymlinkTextInputFormat.java:100:30: [cast] redundant cast to SymlinkTextInputSplit`
### Why are the changes needed?
to get rid of compilation warning and redundant type cast
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By existing unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38895: [MINOR][SQL] Get rid of redundant type cast
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38895:
URL: https://github.com/apache/spark/pull/38895#issuecomment-1336422884
This is too minor; are there multiple changes like this you can batch together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] NarekDW commented on pull request #38895: [MINOR][SQL] Get rid of redundant type cast
Posted by GitBox <gi...@apache.org>.
NarekDW commented on PR #38895:
URL: https://github.com/apache/spark/pull/38895#issuecomment-1337519684
> Oh, these are all in hive code. This is a copy of some code from Hive, so unless we must change something, it's simpler to leave it as-is to faciliate updating by copying new source files
Okay, got it, I'm closing the PR then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] NarekDW commented on pull request #38895: [MINOR][SQL] Get rid of redundant type cast
Posted by GitBox <gi...@apache.org>.
NarekDW commented on PR #38895:
URL: https://github.com/apache/spark/pull/38895#issuecomment-1336483836
> This is too minor; are there multiple changes like this you can batch together?
Yep, let me add them to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] NarekDW closed pull request #38895: [MINOR][SQL] Get rid of redundant type cast
Posted by GitBox <gi...@apache.org>.
NarekDW closed pull request #38895: [MINOR][SQL] Get rid of redundant type cast
URL: https://github.com/apache/spark/pull/38895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38895: [MINOR][SQL] Get rid of redundant type cast
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38895:
URL: https://github.com/apache/spark/pull/38895#issuecomment-1336269897
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org