[jira] [Comment Edited] (HBASE-20860) Merged region's RIT state may not be cleaned after master restart

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538654#comment-16538654 ] 

stack edited comment on HBASE-20860 at 7/10/18 2:19 PM:
--------------------------------------------------------

bq. Normally, if the region is marked as CLOSED, and no procedure is attached to it, it is a bug, we need to treat it as RIT so we can see them form master web clearly

Ok. Or, rather, in this case, there is an associated procedure -- the MergeTableRegionsProcedure. We check if table disabling or disabled if state is CLOSED. Would it be better to not schedule the RIT since we have the MTRP going on. Hard part is figuring if MTRP is on-going....

So, for now, the patch is good.

Would it be cleaner calling removeFromOfflineRegions inside in markRegionAsMerged  rather than after markRegionAsMerged in MergeTableRegionsProcedure?

Thanks [~allan163]




was (Author: stack):
bq. Normally, if the region is marked as CLOSED, and no procedure is attached to it, it is a bug, we need to treat it as RIT so we can see them form master web clearly

Ok.



> Merged region's RIT state may not be cleaned after master restart
> -----------------------------------------------------------------
>
>                 Key: HBASE-20860
>                 URL: https://issues.apache.org/jira/browse/HBASE-20860
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0, 2.1.0, 2.0.1
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0, 2.0.2
>
>         Attachments: HBASE-20860.branch-2.0.002.patch, HBASE-20860.branch-2.0.003.patch, HBASE-20860.branch-2.0.004.patch, HBASE-20860.branch-2.0.patch
>
>
> In MergeTableRegionsProcedure, we issue UnassignProcedures to offline regions to merge. But if we restart master just after MergeTableRegionsProcedure finished these two UnassignProcedure and before it can delete their meta entries. The new master will found these two region is CLOSED but no procedures are attached to them. They will be regard as RIT regions and nobody will clean the RIT state for them later.
> A quick way to resolve this stuck situation in the production env is restarting master again, since the meta entries are deleted in MergeTableRegionsProcedure. Here, I offer a fix for this problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)