You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2008/04/08 22:53:58 UTC
[jira] Commented: (MPIR-85) Refactoring of dependency and
dependency management report
[ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=130185#action_130185 ]
Dennis Lundberg commented on MPIR-85:
-------------------------------------
Nick, which of the three patch files is it that should be applied? I'm a bit confused...
> Refactoring of dependency and dependency management report
> ----------------------------------------------------------
>
> Key: MPIR-85
> URL: http://jira.codehaus.org/browse/MPIR-85
> Project: Maven 2.x Project Info Reports Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Nick Stolwijk
> Attachments: comparators.patch, refactor.patch, refactor.patch
>
>
> I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code.
> Important improvements:
> - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer.
> If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that.
> - I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests.
> Please tell me what you think of it. I know it is only a start.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira