You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/28 13:14:45 UTC
[GitHub] [spark] sarutak commented on a change in pull request #34425: [SPARK-37105][SQL][FOLLOWUP] Change HiveExternalCatalogVersionsSuite to be able to test with Java 17
sarutak commented on a change in pull request #34425:
URL: https://github.com/apache/spark/pull/34425#discussion_r738377465
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -263,6 +267,8 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
versions
.filter(v => v.startsWith("3") || !TestUtils.isPythonVersionAtLeast38())
.filter(v => v.startsWith("3") || !SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
+ .filter(v => !((v.startsWith("3.0") || v.startsWith("3.1")) &&
+ SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_17)))
Review comment:
Due to [this issue](https://github.com/scala/scala/pull/9676), this test doesn't work with Java 17 for Spark 3.0 and Spark 3.1 which uses Scala `< 2.12.15`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org