[GitHub] [maven-resolver] rfscholte commented on a change in pull request #83: [MRESOLVER-151] Enforce a checksum policy to be provided explicitly

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #83:
URL: https://github.com/apache/maven-resolver/pull/83#discussion_r547974159



##########
File path: maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultChecksumPolicyProviderTest.java
##########
@@ -124,7 +124,7 @@ public void testGetEffectiveChecksumPolicy_DifferentPolicies()
         }
     }
 
-    @Test
+    @Test( expected = IllegalArgumentException.class )

Review comment:
       With the change it'll exit with the first testcase and the first assert, making the rest useless.
   Better replace every `assertEquals` with something like
   
       IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> provider.getEffectiveChecksumPolicy(.....) );
       assertThat( ex.getMessage(), is(...))




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org