You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/10 06:51:02 UTC
[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #10847: Add on_kill method to DataprocSubmitJobOperator
michalslowikowski00 commented on a change in pull request #10847:
URL: https://github.com/apache/airflow/pull/10847#discussion_r486104628
##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -1808,6 +1808,8 @@ def __init__(
gcp_conn_id: str = "google_cloud_default",
impersonation_chain: Optional[Union[str, Sequence[str]]] = None,
asynchronous: bool = False,
+ hook: Optional[DataprocHook] = None,
+ job_id: str = '',
Review comment:
I think we always use such notation.
```suggestion
job_id: str,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org