[GitHub] [tvm] AndrewZhaoLuo commented on a diff in pull request #11530: [PROFILER] Add configuration information to profiler

[GitBox <gi...@apache.org>]

AndrewZhaoLuo commented on code in PR #11530:
URL: https://github.com/apache/tvm/pull/11530#discussion_r890290381


##########
src/runtime/profiling.cc:
##########
@@ -592,14 +617,20 @@ String ReportNode::AsTable(bool sort, bool aggregate, bool compute_col_sums) con
     }
     s << std::endl;
   }
+
+  // Add configuration information. It will not be aligned with the columns.
+  s << std::endl << "Configuration" << std::endl << "-------------" << std::endl;
+  for (auto kv : configuration) {
+    s << kv.first << ": " << print_metric(kv.second) << std::endl;
+  }
   return s.str();
 }
 
 std::string DeviceString(Device dev) {
   return DeviceName(dev.device_type) + std::to_string(dev.device_id);
 }
 
-Report Profiler::Report(bool aggregate, bool sort) {
+Report Profiler::Report() {

Review Comment:
   Interesting these variables were never used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org