You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2004/07/16 15:36:34 UTC

Re: ViewCVS URL in mailer hook script

[crossposting to dev@]

"Bruce A. Mah" <bm...@acm.org> writes:

> I'm sure this has been asked a gazillion times before, but I can't seem
> to find an answer in the source code or the mailing list archives.

Actually, it's never been asked (that I know).

> How does the mailer hook script used by the subversion repository on
> svn.collab.net (i.e. the repository holding the subversion source code
> itself) generate the ViewCVS URLs in the mails that go to svn@?

Because I have a custom patch to it which adds this support.  I've
been hesitent to commit the work because I'm not sure it's "right" for
Subversion's mailer script to add support for one particular
third-party tool.  That would open the door for support for *all* such
third-party tools, and that's not a burder I think the script should
bear.  I could post the patch, or toss into a contrib/ directory, I
suppose.

Do others here have any opinion on this? 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: ViewCVS URL in mailer hook script

Posted by Klaus Rennecke <kr...@tigris.org>.
C. Michael Pilato wrote:
> [...]  I could post the patch, or toss into a contrib/ directory, I
> suppose. [...]

Contrib sounds nice, pretty please. I've been looking for something like 
this. :-)

/Klaus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: ViewCVS URL in mailer hook script

Posted by Klaus Rennecke <kr...@tigris.org>.
C. Michael Pilato wrote:
> [...]  I could post the patch, or toss into a contrib/ directory, I
> suppose. [...]

Contrib sounds nice, pretty please. I've been looking for something like 
this. :-)

/Klaus

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

RE: ViewCVS URL in mailer hook script

Posted by Sander Striker <st...@apache.org>.
> From: cmpilato@localhost.localdomain 
> [mailto:cmpilato@localhost.localdomain] On Behalf Of C. Michael Pilato
> Sent: Friday, July 16, 2004 5:37 PM

> [crossposting to dev@]
> 
> "Bruce A. Mah" <bm...@acm.org> writes:
> 
> > I'm sure this has been asked a gazillion times before, but I can't 
> > seem to find an answer in the source code or the mailing 
> list archives.
> 
> Actually, it's never been asked (that I know).
> 
> > How does the mailer hook script used by the subversion 
> repository on 
> > svn.collab.net (i.e. the repository holding the subversion 
> source code
> > itself) generate the ViewCVS URLs in the mails that go to svn@?
> 
> Because I have a custom patch to it which adds this support.  
> I've been hesitent to commit the work because I'm not sure 
> it's "right" for Subversion's mailer script to add support 
> for one particular third-party tool.  That would open the 
> door for support for *all* such third-party tools, and that's 
> not a burder I think the script should bear.  I could post 
> the patch, or toss into a contrib/ directory, I suppose.
> 
> Do others here have any opinion on this? 

I have a local patch to all my installations as well FWIW.
I never even realised there was a patched mailer.py on svn.collab.net... :)

Sander


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

RE: ViewCVS URL in mailer hook script

Posted by Sander Striker <st...@apache.org>.
> From: cmpilato@localhost.localdomain 
> [mailto:cmpilato@localhost.localdomain] On Behalf Of C. Michael Pilato
> Sent: Friday, July 16, 2004 5:37 PM

> [crossposting to dev@]
> 
> "Bruce A. Mah" <bm...@acm.org> writes:
> 
> > I'm sure this has been asked a gazillion times before, but I can't 
> > seem to find an answer in the source code or the mailing 
> list archives.
> 
> Actually, it's never been asked (that I know).
> 
> > How does the mailer hook script used by the subversion 
> repository on 
> > svn.collab.net (i.e. the repository holding the subversion 
> source code
> > itself) generate the ViewCVS URLs in the mails that go to svn@?
> 
> Because I have a custom patch to it which adds this support.  
> I've been hesitent to commit the work because I'm not sure 
> it's "right" for Subversion's mailer script to add support 
> for one particular third-party tool.  That would open the 
> door for support for *all* such third-party tools, and that's 
> not a burder I think the script should bear.  I could post 
> the patch, or toss into a contrib/ directory, I suppose.
> 
> Do others here have any opinion on this? 

I have a local patch to all my installations as well FWIW.
I never even realised there was a patched mailer.py on svn.collab.net... :)

Sander


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org