You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb AT ASF <se...@apache.org> on 2014/03/19 18:56:30 UTC

Re: svn commit: r1579320 - /jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java

On 19 March 2014 17:52,  <se...@apache.org> wrote:
> Author: sebb
> Date: Wed Mar 19 17:52:29 2014
> New Revision: 1579320
>
> URL: http://svn.apache.org/r1579320
> Log:
> Another way to fix the Javadoc warning which does not require an import

I think it's better to reserve imports for code only.

> Modified:
>     jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java?rev=1579320&r1=1579319&r2=1579320&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java Wed Mar 19 17:52:29 2014
> @@ -26,11 +26,11 @@ import java.util.Map;
>  import org.apache.jmeter.functions.InvalidVariableException;
>  import org.apache.jmeter.testelement.property.JMeterProperty;
>  import org.apache.jmeter.testelement.property.StringProperty;
> -import org.apache.jmeter.threads.JMeterVariables;
>  import org.apache.jmeter.util.StringUtilities;
>
>  /**
> - * Replaces ${key} by value extracted from {@link JMeterVariables} if any
> + * Replaces ${key} by value extracted from
> + * {@link org.apache.jmeter.threads.JMeterVariables JMeterVariables} if any
>   */
>  public class UndoVariableReplacement extends AbstractTransformer {
>      public UndoVariableReplacement(CompoundVariable masterFunction, Map<String, String> variables) {
>
>

Re: svn commit: r1579320 - /jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java

Posted by Milamber <mi...@apache.org>.
Le 19/03/2014 17:56, sebb AT ASF a ecrit :
> On 19 March 2014 17:52,  <se...@apache.org> wrote:
>> Author: sebb
>> Date: Wed Mar 19 17:52:29 2014
>> New Revision: 1579320
>>
>> URL: http://svn.apache.org/r1579320
>> Log:
>> Another way to fix the Javadoc warning which does not require an import
> I think it's better to reserve imports for code only.

Yes it's better.
Thanks for fix of the fix ;)


>> Modified:
>>      jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java
>>
>> Modified: jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java?rev=1579320&r1=1579319&r2=1579320&view=diff
>> ==============================================================================
>> --- jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java (original)
>> +++ jmeter/trunk/src/core/org/apache/jmeter/engine/util/UndoVariableReplacement.java Wed Mar 19 17:52:29 2014
>> @@ -26,11 +26,11 @@ import java.util.Map;
>>   import org.apache.jmeter.functions.InvalidVariableException;
>>   import org.apache.jmeter.testelement.property.JMeterProperty;
>>   import org.apache.jmeter.testelement.property.StringProperty;
>> -import org.apache.jmeter.threads.JMeterVariables;
>>   import org.apache.jmeter.util.StringUtilities;
>>
>>   /**
>> - * Replaces ${key} by value extracted from {@link JMeterVariables} if any
>> + * Replaces ${key} by value extracted from
>> + * {@link org.apache.jmeter.threads.JMeterVariables JMeterVariables} if any
>>    */
>>   public class UndoVariableReplacement extends AbstractTransformer {
>>       public UndoVariableReplacement(CompoundVariable masterFunction, Map<String, String> variables) {
>>
>>