You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/12/06 20:06:52 UTC

[GitHub] qpid-dispatch pull request #425: DISPATCH-1213 - Prevent stalling of presett...

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/425

    DISPATCH-1213 - Prevent stalling of presettled large message senders …

    …by calling the AMQP_rx_handler which start emptying proton buffers again

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1213

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #425
    
----
commit e8124dced7a70f6126f643959cac4603dcae0fbb
Author: Ganesh Murthy <gm...@...>
Date:   2018-12-06T20:00:30Z

    DISPATCH-1213 - Prevent stalling of presettled large message senders by calling the AMQP_rx_handler which start emptying proton buffers again

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-dispatch issue #425: DISPATCH-1213 - Prevent stalling of presettled lar...

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/425
  
    # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=h1) Report
    > Merging [#425](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/2dde7030fb032a54fdefe5b7c5c4a39a4f1bfd6e?src=pr&el=desc) will **decrease** coverage by `<.01%`.
    > The diff coverage is `100%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/425/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #425      +/-   ##
    ==========================================
    - Coverage   87.93%   87.92%   -0.01%     
    ==========================================
      Files          85       85              
      Lines       18236    18243       +7     
    ==========================================
    + Hits        16035    16041       +6     
    - Misses       2201     2202       +1
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=tree) | Coverage Δ | |
    |---|---|---|
    | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.28% <100%> (+0.38%)` | :arrow_up: |
    | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.21% <100%> (ø)` | :arrow_up: |
    | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `94.64% <0%> (-1.79%)` | :arrow_down: |
    | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `77.01% <0%> (-0.77%)` | :arrow_down: |
    | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.27% <0%> (-0.57%)` | :arrow_down: |
    | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `88.04% <0%> (-0.26%)` | :arrow_down: |
    | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.36% <0%> (-0.25%)` | :arrow_down: |
    | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.2% <0%> (-0.13%)` | :arrow_down: |
    | [src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j) | `94.36% <0%> (+0.7%)` | :arrow_up: |
    | ... and [2 more](https://codecov.io/gh/apache/qpid-dispatch/pull/425/diff?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=footer). Last update [2dde703...e8124dc](https://codecov.io/gh/apache/qpid-dispatch/pull/425?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org