[GitHub] [hive] pvary commented on a change in pull request #2780: HIVE-25688: Non blocking DROP PARTITION implementation

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2780:
URL: https://github.com/apache/hive/pull/2780#discussion_r770385940



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
##########
@@ -103,34 +105,40 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition
     re.noLockNeeded();
     inputs.add(re);
 
-    addTableDropPartsOutputs(table, partitionSpecs.values(), !ifExists);
-
+    boolean dropPartUseBase = HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_DROP_PARTITION_USE_BASE)
+        || HiveConf.getBoolVar(conf, ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED)
+      && AcidUtils.isTransactionalTable(table);
+    
+    addTableDropPartsOutputs(table, partitionSpecs.values(), !ifExists, dropPartUseBase);
+    
     AlterTableDropPartitionDesc desc =
-        new AlterTableDropPartitionDesc(tableName, partitionSpecs, mustPurge, replicationSpec);
-    rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc)));
-
-    postProcess(tableName, table, desc);

Review comment:
       Removed the `postProcess`. Is it intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org