You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "cbalci (via GitHub)" <gi...@apache.org> on 2023/04/21 16:50:23 UTC
[GitHub] [pinot] cbalci opened a new pull request, #10663: [Spark Connector] Escape column names when querying Pinot
cbalci opened a new pull request, #10663:
URL: https://github.com/apache/pinot/pull/10663
This fixes issues with reading columns with reserved names like 'timestamp'.
**Testing**
- Unit tests are updated accordingly
- Manually tested using the `ExampleSparkPinotConnectorTest` suite
`bugfix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10663: [Spark Connector] Escape column names when querying Pinot
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10663:
URL: https://github.com/apache/pinot/pull/10663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10663: [Spark Connector] Escape column names when querying Pinot
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10663:
URL: https://github.com/apache/pinot/pull/10663#issuecomment-1518174869
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10663?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10663](https://codecov.io/gh/apache/pinot/pull/10663?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0474285) into [master](https://codecov.io/gh/apache/pinot/commit/178aa200a78d5ecebff163529c965739ac2594e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (178aa20) will **increase** coverage by `42.60%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #10663 +/- ##
=============================================
+ Coverage 27.74% 70.34% +42.60%
- Complexity 58 6514 +6456
=============================================
Files 2090 2108 +18
Lines 112642 113665 +1023
Branches 16987 17126 +139
=============================================
+ Hits 31247 79954 +48707
+ Misses 78272 28108 -50164
- Partials 3123 5603 +2480
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.39% <ø> (-0.07%)` | :arrow_down: |
| integration2 | `24.00% <ø> (+0.09%)` | :arrow_up: |
| unittests1 | `67.91% <ø> (?)` | |
| unittests2 | `13.87% <75.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nector/spark/common/query/ScanQueryGenerator.scala](https://codecov.io/gh/apache/pinot/pull/10663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL3F1ZXJ5L1NjYW5RdWVyeUdlbmVyYXRvci5zY2FsYQ==) | `93.93% <50.00%> (ø)` | |
| [...ot/connector/spark/common/PinotClusterClient.scala](https://codecov.io/gh/apache/pinot/pull/10663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1zcGFyay1jb21tb24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9waW5vdC9jb25uZWN0b3Ivc3BhcmsvY29tbW9uL1Bpbm90Q2x1c3RlckNsaWVudC5zY2FsYQ==) | `5.15% <100.00%> (ø)` | |
... and [1496 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10663/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org