[GitHub] [airflow] ephraimbuddy commented on a change in pull request #21116: Ensure clear_task_instances sets valid run state

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #21116:
URL: https://github.com/apache/airflow/pull/21116#discussion_r792458108



##########
File path: airflow/models/taskinstance.py
##########
@@ -220,7 +220,7 @@ def clear_task_instances(
                 # outdated. We make max_tries the maximum value of its
                 # original max_tries or the last attempted try number.
                 ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries)
-            ti.state = State.NONE
+            ti.state = TaskInstanceState.NONE

Review comment:
       I have had an issue with `TaskInstanceState.NONE`, it gives the string 'None' instead of a null value. We should use State.NONE instead




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org