You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/17 16:26:38 UTC
[GitHub] [trafficcontrol] limited opened a new pull request #4967: Allow Traffic Router binding DNS sockets to specific IP Address
limited opened a new pull request #4967:
URL: https://github.com/apache/trafficcontrol/pull/4967
## What does this PR (Pull Request) do?
- [x] This PR fixes #4361
## Which Traffic Control components are affected by this PR?
- Documentation
- Traffic Router
## What is the best way to verify this PR?
- Set in dns.properties
```
dns.udp.host=127.0.0.1
dns.tcp.host=127.0.0.1
```
- Start Traffic Router
- Confirm listening IPs with `netstat -anlp | grep ":53"`
- Verify with dig (`dig @127.0.0.1 <hostname>`) that TR can only be reached via the loopback IP and not through any other IP present on the server
## The following criteria are ALL met by this PR
- [x] I have explained why tests are unnecessary
- [x] This PR includes documentation
- [x] This PR includes an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
- No UTs as there is not a good way to test applicationContext changes
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] limited commented on a change in pull request #4967: Allow Traffic Router binding DNS sockets to specific IP Address
Posted by GitBox <gi...@apache.org>.
limited commented on a change in pull request #4967:
URL: https://github.com/apache/trafficcontrol/pull/4967#discussion_r479332260
##########
File path: traffic_router/core/src/main/webapp/WEB-INF/applicationContext.xml
##########
@@ -297,9 +297,14 @@
<constructor-arg index="4" ref="TCPBlockingQueue" />
</bean>
+ <bean id="DnsStreamInetAddress" class="java.net.InetAddress" factory-method="getByName">
Review comment:
changed spaces to tabs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 merged pull request #4967: Allow Traffic Router binding DNS sockets to specific IP Address
Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #4967:
URL: https://github.com/apache/trafficcontrol/pull/4967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4967: Allow Traffic Router binding DNS sockets to specific IP Address
Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on a change in pull request #4967:
URL: https://github.com/apache/trafficcontrol/pull/4967#discussion_r478553276
##########
File path: traffic_router/core/src/main/webapp/WEB-INF/applicationContext.xml
##########
@@ -297,9 +297,14 @@
<constructor-arg index="4" ref="TCPBlockingQueue" />
</bean>
+ <bean id="DnsStreamInetAddress" class="java.net.InetAddress" factory-method="getByName">
Review comment:
looks like some white space differences for all the changes in this file. prob spaces vs tabs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org