You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/06 20:31:00 UTC

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #6870: Dynamic gpu tests, add dynamic strided slice to topi

mbrookhart opened a new pull request #6870:
URL: https://github.com/apache/incubator-tvm/pull/6870


   cc @zhiics 
   
   Like I said, this is from my topk branch, which is still having issues with memory corruption, so I'm not actually using the topi version by this commit.
   
   Let me know if this works for argwhere, I'll try to update it with a topi unit test this afternoon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on pull request #6870: Dynamic gpu tests, add dynamic strided slice to topi

Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #6870:
URL: https://github.com/apache/incubator-tvm/pull/6870#issuecomment-723305330


   @mbrookhart Thanks for the PR. I think this probably solves the problem if we invoke from Relay directly. But similarly to topk, argwhere also needs to invoke strided_slice in topi. I think we also need to have a dispatch in topi to invoke each dyn_strided_slice or strided_slice.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] kevinthesun merged pull request #6870: Dynamic gpu tests, add dynamic strided slice to topi

Posted by GitBox <gi...@apache.org>.
kevinthesun merged pull request #6870:
URL: https://github.com/apache/incubator-tvm/pull/6870


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mbrookhart commented on pull request #6870: Dynamic gpu tests, add dynamic strided slice to topi

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #6870:
URL: https://github.com/apache/incubator-tvm/pull/6870#issuecomment-723333814


   added the python api and tests
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mbrookhart commented on pull request #6870: Dynamic gpu tests, add dynamic strided slice to topi

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #6870:
URL: https://github.com/apache/incubator-tvm/pull/6870#issuecomment-723310203


   Oops! I was missing part of it in this commit, let me extract it from the other branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] kevinthesun commented on pull request #6870: Dynamic gpu tests, add dynamic strided slice to topi

Posted by GitBox <gi...@apache.org>.
kevinthesun commented on pull request #6870:
URL: https://github.com/apache/incubator-tvm/pull/6870#issuecomment-725730837


   Thanks! @mbrookhart @zhiics 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org