You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Jochen Kemnade (JIRA)" <ji...@apache.org> on 2012/06/06 10:19:23 UTC
[jira] [Created] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Jochen Kemnade created TAP5-1949:
------------------------------------
Summary: Alerts component does not show alerts added from a component that occurs later in the template
Key: TAP5-1949
URL: https://issues.apache.org/jira/browse/TAP5-1949
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3.3
Reporter: Jochen Kemnade
Priority: Minor
Consider the following snippet:
<t:alerts />
<t:componentthataddsanalert />
The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422250#comment-13422250 ]
Massimo Lusetti commented on TAP5-1949:
---------------------------------------
Would you mind to flag the patch as Apache licensed?
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti resolved TAP5-1949.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.4
5.3.5
Thanks for the patch Joachen Kemnade
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Fix For: 5.3.5, 5.4
>
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Kemnade updated TAP5-1949:
---------------------------------
Affects Version/s: 5.3.4
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Kemnade updated TAP5-1949:
---------------------------------
Affects Version/s: 5.4
Same problem and fix for 5.4
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293433#comment-13293433 ]
Massimo Lusetti commented on TAP5-1949:
---------------------------------------
I like the proposed behavior. Did anyone see a draw back in this changes?
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422250#comment-13422250 ]
Massimo Lusetti commented on TAP5-1949:
---------------------------------------
Would you mind to flag the patch as Apache licensed?
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Kemnade updated TAP5-1949:
---------------------------------
Attachment: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
patch that defers the alerts JS initialization to allow for alerts being added by components that occur later in the template
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422920#comment-13422920 ]
Jochen Kemnade commented on TAP5-1949:
--------------------------------------
If I am not mistaken, I've already done that, at least the attachment management says so.
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Kemnade updated TAP5-1949:
---------------------------------
Affects Version/s: 5.3.4
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Kemnade updated TAP5-1949:
---------------------------------
Affects Version/s: 5.4
Same problem and fix for 5.4
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293395#comment-13293395 ]
Jochen Kemnade commented on TAP5-1949:
--------------------------------------
The term "during the render of the page" is somewhat misleasing. The alerts are generated during the setup-render phase of an embedded component. The exact use case is a component whose rendering is effected by users's settings. There can be misconfigurations (related to conflicts between session state and persisted settings) that lead to a message being displayed to the user. As the component detects that error itself, it registers an alert with the alert manager. But if the alerts component is contained in the layout component, its begin-render phase (which generated the client-side JS for the alerts to be shown) is executed before the component's setup-render, so the messages are not added.
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293133#comment-13293133 ]
Howard M. Lewis Ship commented on TAP5-1949:
--------------------------------------------
What is your use case where new Alerts are generated during the render of the page?
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423622#comment-13423622 ]
Hudson commented on TAP5-1949:
------------------------------
Integrated in tapestry-trunk-freestyle #814 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/814/])
[TAP5-1949] Defer alerts initialization to catch them all (Revision ec216f2a0e6684fc7c747603894e218bd6ec514d)
Result = FAILURE
mlusetti :
Files :
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Alerts.java
* tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/AlertsDemo.java
* tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/components/ErrorComponent.java
* tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/AlertsDemo.tml
* tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Fix For: 5.3.5, 5.4
>
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti resolved TAP5-1949.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.4
5.3.5
Thanks for the patch Joachen Kemnade
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Fix For: 5.3.5, 5.4
>
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423622#comment-13423622 ]
Hudson commented on TAP5-1949:
------------------------------
Integrated in tapestry-trunk-freestyle #814 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/814/])
[TAP5-1949] Defer alerts initialization to catch them all (Revision ec216f2a0e6684fc7c747603894e218bd6ec514d)
Result = FAILURE
mlusetti :
Files :
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Alerts.java
* tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/AlertsDemo.java
* tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/components/ErrorComponent.java
* tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/AlertsDemo.tml
* tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Fix For: 5.3.5, 5.4
>
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti reassigned TAP5-1949:
-------------------------------------
Assignee: Massimo Lusetti
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423050#comment-13423050 ]
Massimo Lusetti commented on TAP5-1949:
---------------------------------------
Cool... I don't see the apache flag but I'll take your comment as the agreement
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423050#comment-13423050 ]
Massimo Lusetti commented on TAP5-1949:
---------------------------------------
Cool... I don't see the apache flag but I'll take your comment as the agreement
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jochen Kemnade updated TAP5-1949:
---------------------------------
Attachment: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
patch that defers the alerts JS initialization to allow for alerts being added by components that occur later in the template
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293133#comment-13293133 ]
Howard M. Lewis Ship commented on TAP5-1949:
--------------------------------------------
What is your use case where new Alerts are generated during the render of the page?
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1949) Alerts component does not show alerts
added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti reassigned TAP5-1949:
-------------------------------------
Assignee: Massimo Lusetti
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293433#comment-13293433 ]
Massimo Lusetti commented on TAP5-1949:
---------------------------------------
I like the proposed behavior. Did anyone see a draw back in this changes?
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422920#comment-13422920 ]
Jochen Kemnade commented on TAP5-1949:
--------------------------------------
If I am not mistaken, I've already done that, at least the attachment management says so.
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.3.4, 5.4
> Reporter: Jochen Kemnade
> Assignee: Massimo Lusetti
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1949) Alerts component does not show
alerts added from a component that occurs later in the template
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293395#comment-13293395 ]
Jochen Kemnade commented on TAP5-1949:
--------------------------------------
The term "during the render of the page" is somewhat misleasing. The alerts are generated during the setup-render phase of an embedded component. The exact use case is a component whose rendering is effected by users's settings. There can be misconfigurations (related to conflicts between session state and persisted settings) that lead to a message being displayed to the user. As the component detects that error itself, it registers an alert with the alert manager. But if the alerts component is contained in the layout component, its begin-render phase (which generated the client-side JS for the alerts to be shown) is executed before the component's setup-render, so the messages are not added.
> Alerts component does not show alerts added from a component that occurs later in the template
> ----------------------------------------------------------------------------------------------
>
> Key: TAP5-1949
> URL: https://issues.apache.org/jira/browse/TAP5-1949
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.3, 5.4
> Reporter: Jochen Kemnade
> Priority: Minor
> Labels: patch
> Attachments: 0001-defer-the-alerts-JS-initialization-to-allow-for-aler.patch
>
>
> Consider the following snippet:
> <t:alerts />
> <t:componentthataddsanalert />
> The alert will not be shown as the JS for the alerts is generated in the beginRender phase of the alerts component. and alerts that are added later are ignored until its next rendering.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira