[GitHub] [cloudstack] GabrielBrascher commented on pull request #5353: Improve VMWare logs

[GitBox <gi...@apache.org>]

GabrielBrascher commented on pull request #5353:
URL: https://github.com/apache/cloudstack/pull/5353#issuecomment-919366698


   @SadiJr I did not understand your answer regarding the raised point by @RodrigoDLopez and @sureshanaparti.
   @RodrigoDLopez seems to have already addressed a bit of the point with an approach that does pretty much what you are doing.
   
   The fact that the input of a method is an abstract class (used there as an identifier so any of the commands that extend it would fit into it) does not mean that it would fail to parse the JSON. At least not in the context you are already parsing the objects.
   
   If you are afraid of such an approach having objects that would not be parsed then it would be better to not parse into JSON at all and revert all your changes to log the Commands without Gson.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org