You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/10 03:42:18 UTC
[GitHub] [shardingsphere] huangdx0726 opened a new pull request, #20911: Rename and move PipelineJobExecutor
huangdx0726 opened a new pull request, #20911:
URL: https://github.com/apache/shardingsphere/pull/20911
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- Rename PipelineJobExecutor to PipelineMetaDataNodeWatcher
- Move PipelineMetaDataNodeWatcher to package `org.apache.shardingsphere.data.pipeline.core.metadata.node`
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #20911: Rename and move PipelineJobExecutor
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20911:
URL: https://github.com/apache/shardingsphere/pull/20911#issuecomment-1246157831
@huangdx0726 , thanks for your contribution. And it's better to mention the related issue, so the issue author could find new PR sooner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #20911: Rename and move PipelineJobExecutor
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #20911:
URL: https://github.com/apache/shardingsphere/pull/20911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20911: Rename and move PipelineJobExecutor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20911:
URL: https://github.com/apache/shardingsphere/pull/20911#issuecomment-1242625305
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20911](https://codecov.io/gh/apache/shardingsphere/pull/20911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93d3a4e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0e00ae0ffec9f805a44d282158f52aee7b693ce7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e00ae0) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #20911 +/- ##
=========================================
Coverage 61.70% 61.70%
Complexity 2464 2464
=========================================
Files 4026 4026
Lines 55563 55563
Branches 9423 9423
=========================================
Hits 34284 34284
Misses 18398 18398
Partials 2881 2881
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../data/pipeline/core/execute/PipelineJobWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/20911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvZXhlY3V0ZS9QaXBlbGluZUpvYldvcmtlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ore/metadata/node/PipelineMetaDataNodeWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/20911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvbWV0YWRhdGEvbm9kZS9QaXBlbGluZU1ldGFEYXRhTm9kZVdhdGNoZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org