You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/19 17:09:05 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11313: tests: Parameterize some tests in alerts_tests.py
codecov-io edited a comment on pull request #11313:
URL: https://github.com/apache/incubator-superset/pull/11313#issuecomment-710698718
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=h1) Report
> Merging [#11313](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/afee008a10f5c7fc9772f2d5a63a7563c4736e17?el=desc) will **decrease** coverage by `5.47%`.
> The diff coverage is `95.95%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11313/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11313 +/- ##
==========================================
- Coverage 65.61% 60.14% -5.48%
==========================================
Files 834 394 -440
Lines 39565 24924 -14641
Branches 3610 0 -3610
==========================================
- Hits 25961 14990 -10971
+ Misses 13495 9934 -3561
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.14% <95.95%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <50.00%> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.12% <95.12%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11313/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=footer). Last update [afee008...c878bf6](https://codecov.io/gh/apache/incubator-superset/pull/11313?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org