You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/25 00:05:22 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33811: [SPARK-36563][SQL] dynamicPartitionOverwrite can direct rename to targetPath instead of partition path one by one when targetPath is empty
dongjoon-hyun commented on a change in pull request #33811:
URL: https://github.com/apache/spark/pull/33811#discussion_r695296611
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1224,6 +1224,16 @@ object SQLConf {
.stringConf
.createOptional
+ val FILE_STAGING_DIR =
+ buildConf("spark.sql.source.stagingDir")
Review comment:
This looks orthogonal what your PR aims. Could you spin off this new configuration as a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org