[jira] [Comment Edited] (MSHADE-363) Breaking change to ResourceTransformer's API

["Andy Wilkinson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097361#comment-17097361 ] 

Andy Wilkinson edited comment on MSHADE-363 at 5/1/20, 1:45 PM:
----------------------------------------------------------------

If reverting the change is not an option, requiring Java 8 and adding a default method is the only thing that I can think of. 


was (Author: awilkinson):
If reverting the change is not an option, requiring Java 8 and adding a default method is thing that I can think of. 

> Breaking change to ResourceTransformer's API
> --------------------------------------------
>
>                 Key: MSHADE-363
>                 URL: https://issues.apache.org/jira/browse/MSHADE-363
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.2.3
>            Reporter: Andy Wilkinson
>            Priority: Major
>
> A Spring Boot user has [made us aware|https://github.com/spring-projects/spring-boot/issues/21128] of a [breaking change to the API of ResourceTransformer|https://github.com/apache/maven-shade-plugin/commit/0d7bfb53a5fd83eede7edfd5552db5fa561d6286#diff-f09094e2212bb4d1173a4e183635b958] in 3.2.3.
> Ideally, we don't want to require a specific version of the Shade plugin. While I think we may be able to support the new and old both variants of the method, it would be preferable if 3.2.3 was backwards compatible with 3.2.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)