You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/27 11:20:11 UTC

[GitHub] [shardingsphere] zjcnb opened a new pull request, #18010: Refactor DatabaseDiscoveryProviderAlgorithm.checkEnvironment implement

zjcnb opened a new pull request, #18010:
URL: https://github.com/apache/shardingsphere/pull/18010

   Fixes #17994 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #18010: Refactor DatabaseDiscoveryProviderAlgorithm.checkEnvironment implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18010:
URL: https://github.com/apache/shardingsphere/pull/18010#issuecomment-1140127580

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18010](https://codecov.io/gh/apache/shardingsphere/pull/18010?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e3e7e2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f3b8fd404b0a4bb4f1c877fb7ca6cec24249d37f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f3b8fd4) will **increase** coverage by `0.00%`.
   > The diff coverage is `80.55%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18010   +/-   ##
   =========================================
     Coverage     58.92%   58.92%           
     Complexity     2145     2145           
   =========================================
     Files          3651     3651           
     Lines         54102    54092   -10     
     Branches       9190     9189    -1     
   =========================================
   - Hits          31878    31875    -3     
   + Misses        19519    19513    -6     
   + Partials       2705     2704    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18010?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ReplicationDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3Zlcnktb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9vcGVuZ2F1c3MvT3BlbkdhdXNzTm9ybWFsUmVwbGljYXRpb25EYXRhYmFzZURpc2NvdmVyeVByb3ZpZGVyQWxnb3JpdGhtLmphdmE=) | `30.00% <ø> (ø)` | |
   | [...ReplicationDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTXlTUUxOb3JtYWxSZXBsaWNhdGlvbkRhdGFiYXNlRGlzY292ZXJ5UHJvdmlkZXJBbGdvcml0aG0uamF2YQ==) | `57.14% <79.16%> (+15.96%)` | :arrow_up: |
   | [...pe/MGRMySQLDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTUdSTXlTUUxEYXRhYmFzZURpc2NvdmVyeVByb3ZpZGVyQWxnb3JpdGhtLmphdmE=) | `66.12% <80.00%> (+2.66%)` | :arrow_up: |
   | [...dbdiscovery/algorithm/DatabaseDiscoveryEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9hbGdvcml0aG0vRGF0YWJhc2VEaXNjb3ZlcnlFbmdpbmUuamF2YQ==) | `45.16% <100.00%> (-3.33%)` | :arrow_down: |
   | [...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9ydWxlL0RhdGFiYXNlRGlzY292ZXJ5UnVsZS5qYXZh) | `61.64% <100.00%> (+1.11%)` | :arrow_up: |
   | [...crypt/metadata/EncryptSchemaMetaDataDecorator.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdFNjaGVtYU1ldGFEYXRhRGVjb3JhdG9yLmphdmE=) | `93.33% <0.00%> (-0.22%)` | :arrow_down: |
   | [.../schema/loader/dialect/H2SchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvSDJTY2hlbWFNZXRhRGF0YUxvYWRlci5qYXZh) | `87.05% <0.00%> (ø)` | |
   | [...ema/loader/dialect/OracleSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvT3JhY2xlU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `86.74% <0.00%> (ø)` | |
   | [.../loader/dialect/SQLServerSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvU1FMU2VydmVyU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `86.53% <0.00%> (ø)` | |
   | ... and [13 more](https://codecov.io/gh/apache/shardingsphere/pull/18010/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18010?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18010?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f3b8fd4...1e3e7e2](https://codecov.io/gh/apache/shardingsphere/pull/18010?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #18010: Refactor DatabaseDiscoveryProviderAlgorithm.checkEnvironment implement

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18010:
URL: https://github.com/apache/shardingsphere/pull/18010


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org